felipecrv commented on code in PR #38426:
URL: https://github.com/apache/arrow/pull/38426#discussion_r1369363345
##########
go/arrow/decimal256/decimal256.go:
##########
@@ -506,7 +506,7 @@ func (n Num) FitsInPrecision(prec int32) bool {
func (n Num) ToString(scale int32) string {
f := (&big.Float{}).SetInt(n.BigInt())
- f.Quo(f, (&big.Float{}).SetInt(scaleMultipliers[scale].BigInt()))
+ f.SetPrec(256).Quo(f,
(&big.Float{}).SetInt(scaleMultipliers[scale].BigInt()))
Review Comment:
Is 256 precision always required? Is there a way to know what precision is
needed? Or why it doesn't matter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
