jonahgao commented on code in PR #7909:
URL: https://github.com/apache/arrow-datafusion/pull/7909#discussion_r1369762989
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -881,6 +910,42 @@ pub fn replace_cols_by_name(
})
}
+/// check whether the expression is volatile predicates
+pub fn is_volatile_expression(e: Expr) -> bool {
Review Comment:
```suggestion
fn is_volatile_expression(e: &Expr) -> bool {
```
- We can pass the argument `e` by reference.
- I would suggest setting the visibility of this function to `private` since
it is only being used within this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
