mustafasrepo commented on code in PR #7919:
URL: https://github.com/apache/arrow-datafusion/pull/7919#discussion_r1370366359
##########
datafusion/expr/src/tree_node/expr.rs:
##########
@@ -47,8 +48,19 @@ impl TreeNode for Expr {
| Expr::TryCast(TryCast { expr, .. })
| Expr::Sort(Sort { expr, .. })
| Expr::InSubquery(InSubquery{ expr, .. }) =>
vec![expr.as_ref().clone()],
- Expr::GetIndexedField(GetIndexedField { expr, .. }) => {
- vec![expr.as_ref().clone()]
+ Expr::GetIndexedField(GetIndexedField { expr, field }) => {
+ let expr = expr.as_ref().clone();
+ match field {
+ GetFieldAccess::ListIndex {key} => {
+ vec![key.as_ref().clone(), expr]
+ },
+ GetFieldAccess::ListRange {start, stop} => {
+ vec![start.as_ref().clone(), stop.as_ref().clone(),
expr]
+ }
+ GetFieldAccess::NamedStructField {name: _name} => {
+ vec![expr]
+ }
Review Comment:
`to_columns` method of the `Expr` were returning missing columns for
`Expr::GetIndexedField`, this change fixes this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
