tustvold commented on code in PR #4971:
URL: https://github.com/apache/arrow-rs/pull/4971#discussion_r1370455540
##########
object_store/src/multipart.rs:
##########
@@ -296,6 +301,11 @@ pub trait MultiPartStore: Send + Sync + 'static {
) -> Result<PartId>;
/// Completes a multipart upload
+ ///
+ /// The `i`'th value of `parts` must be a [`PartId`] returned by a call to
[`Self::put_part`]
+ /// with a `part_idx` of `i`, and the same `path` and `id` as provided to
this method. Calling
+ /// this method with out of sequence or repeated [`PartId`], or [`PartId`]
returned for other
+ /// values of `path` or `id`, will result in implementation-defined
behaviour
Review Comment:
For an example of implementation defined behaviour, Azure will produce a
file with parts in the order passed to this function, regardless of if they are
out of sequence, and if they were uploaded with different values of
`MultipartId`.
Other stores do various combinations of erroring, or producing files with
parts in different orders. Provided people stick to the API contract though,
the behaviour is consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
