crepererum commented on code in PR #4974:
URL: https://github.com/apache/arrow-rs/pull/4974#discussion_r1372758957
##########
object_store/src/azure/credential.rs:
##########
@@ -174,10 +189,10 @@ fn generate_authorization(
u: &Url,
method: &Method,
account: &str,
- key: &str,
+ key: &AzureAccessKey,
) -> String {
let str_to_sign = string_to_sign(h, u, method, account);
- let auth = hmac_sha256(BASE64_STANDARD.decode(key).unwrap(), str_to_sign);
Review Comment:
for other reviewers: this is the actual fix: the key decoding is moved from
an unwrapping/panicky version here to early decoding as part of the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
