alamb opened a new pull request, #7934:
URL: https://github.com/apache/arrow-datafusion/pull/7934

   ## Which issue does this PR close?
   
   Follow on to https://github.com/apache/arrow-datafusion/pull/7745
   
   ## Rationale for this change
   https://github.com/apache/arrow-datafusion/pull/7745 adds a new `parquet` 
feature flag. However, it did by adding a lot of `#[cfg]` over the codebase. 
   
   I believe it is important to keep the codebase as easy to work with as 
possible, to keep the barrier to new contributors down and encourage additional 
contributions. Having many `#[cfg]` in various parts of the code means that 
even people working on things not related to parquet have to worry about those 
cfgs. 
   
   
   
   ## What changes are included in this PR?
   
   1. Removes most of the ` #cfg` and instead isolates the parquet specific 
code to their own modules, with stub implementations when the feature is not 
enabled. 
   
   
   ## Are these changes tested?
   
   Existing tests
   
   ## Are there any user-facing changes?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to