jdye64 commented on code in PR #527:
URL:
https://github.com/apache/arrow-datafusion-python/pull/527#discussion_r1373254215
##########
conda/recipes/meta.yaml:
##########
@@ -41,7 +41,6 @@ requirements:
- {{ compiler('rust') }}
- cargo-bundle-licenses
- maturin >=0.15,<0.16
- - libprotobuf =3
Review Comment:
Substrait can still be supported in a conda environment. A user would just
use `maturin develop/build --features protoc` however instead of having
`libprotobuf` being a pinned dependency. We are learning that having these
pinned dependencies to more native libraries like this often resulting in conda
installation failures due to conflicts with popular libraries like aws
libraries and it just seems safer to take that approach. However, if we want to
take that risk of potential conflicts we could leave `libprotobuf` in the conda
build file. I really don't have much of an opinion either way on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
