bkietz commented on PR #38466: URL: https://github.com/apache/arrow/pull/38466#issuecomment-1781382808
> Should I create a mock-reader? Yes, this pattern is used elsewhere in testing too. `DelayedBufferReader` should work here, I think https://github.com/bkietz/arrow/blob/27981976f7dfd4c4ab7f60677f849439e038fc55/cpp/src/arrow/filesystem/mockfs.cc#L243-L254 > And when IO complete, the io thread call the callback, which will trigger the segment fault. Just adding the regression test to ensure future refactorings don't reintroduce the segfault should be sufficient -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
