kevingurney commented on code in PR #38463:
URL: https://github.com/apache/arrow/pull/38463#discussion_r1373563754
##########
matlab/src/cpp/arrow/matlab/error/error.h:
##########
@@ -202,4 +202,5 @@ namespace arrow::matlab::error {
static const char* INDEX_OUT_OF_RANGE = "arrow:index:OutOfRange";
static const char* BUFFER_VIEW_OR_COPY_FAILED =
"arrow:buffer:ViewOrCopyFailed";
static const char* ARRAY_PRETTY_PRINT_FAILED =
"arrow:array:PrettyPrintFailed";
+ static const char* TABULAR_PRINT_ROW_FAILED =
"arrow:tabular:PrintRowFailed";
Review Comment:
```suggestion
static const char* TABULAR_GET_STRING_AS_ROW_FAILED =
"arrow:tabular:GetStringAsRowFailed";
```
##########
matlab/test/arrow/tabular/tTabularInternal.m:
##########
@@ -62,46 +62,46 @@ function RowWithAllTypes(testCase,
TabularObjectWithAllTypes)
"00:03:44", "00:00:07.000000", "2024-02-10
00:00:00.000000", ...
"107", "143", "36", "51"];
expectedString = strjoin(columnStrs, " | ");
- actualString = proxy.getRowString(struct(Index=int64(1)));
+ actualString = proxy.getRowAsString(struct(Index=int64(1)));
testCase.verifyEqual(actualString, expectedString);
end
function RowWithOneColumn(testCase, TabularObjectWithOneColumn)
- % Verify getRowString successfully returns the expected string
+ % Verify getRowAsString successfully returns the expected string
% when called on a Table/RecordBatch with one column.
proxy = TabularObjectWithOneColumn.Proxy;
expectedString = "1";
- actualString = proxy.getRowString(struct(Index=int64(1)));
+ actualString = proxy.getRowAsString(struct(Index=int64(1)));
testCase.verifyEqual(actualString, expectedString);
end
function RowIndex(testCase, TabularObjectWithThreeRows)
- % Verify getRowString returns the expected string when provided
- % for each row index value supplied.
+ % Verify getRowAsString returns the expected string for
+ % the provided row index.
proxy = TabularObjectWithThreeRows.Proxy;
- actualString = proxy.getRowString(struct(Index=int64(1)));
+ actualString = proxy.getRowAsString(struct(Index=int64(1)));
expectedString = "1 | ""A""";
testCase.verifyEqual(actualString, expectedString);
- actualString = proxy.getRowString(struct(Index=int64(2)));
+ actualString = proxy.getRowAsString(struct(Index=int64(2)));
expectedString = "2 | ""B""";
testCase.verifyEqual(actualString, expectedString);
- actualString = proxy.getRowString(struct(Index=int64(3)));
+ actualString = proxy.getRowAsString(struct(Index=int64(3)));
expectedString = "3 | ""C""";
testCase.verifyEqual(actualString, expectedString);
end
function PrintRowFailed(testCase, TabularObjectWithThreeRows)
Review Comment:
Can you rename this to `GetStringAsRowFailed`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
