CurtHagenlocher commented on code in PR #38481:
URL: https://github.com/apache/arrow/pull/38481#discussion_r1373791284
##########
csharp/src/Apache.Arrow/Arrays/Decimal128Array.cs:
##########
@@ -61,6 +64,31 @@ public Builder AppendRange(IEnumerable<decimal> values)
return Instance;
}
+#if !NETSTANDARD1_3
+ public Builder Append(SqlDecimal value)
+ {
+ Span<byte> bytes = stackalloc byte[DataType.ByteWidth];
+ DecimalUtility.GetBytes(value, DataType.Precision,
DataType.Scale, bytes);
+
+ return Append(bytes);
+ }
+
+ public Builder AppendRange(IEnumerable<SqlDecimal> values)
+ {
+ if (values == null)
+ {
+ throw new ArgumentNullException(nameof(values));
+ }
+
+ foreach (decimal d in values)
Review Comment:
Oops. Maybe it goes without saying that this code path doesn't have a
test...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
