pitrou commented on a change in pull request #9164:
URL: https://github.com/apache/arrow/pull/9164#discussion_r555793625
##########
File path: cpp/src/arrow/compute/kernels/scalar_set_lookup.cc
##########
@@ -272,10 +278,9 @@ struct IsInVisitor {
Status Visit(const DataType&) {
const auto& state = checked_cast<const
SetLookupState<NullType>&>(*ctx->state());
+ // XXX should skip_nulls be taken into account?
Review comment:
Good point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
