Weijun-H commented on code in PR #7940:
URL: https://github.com/apache/arrow-datafusion/pull/7940#discussion_r1374179263
##########
.github/workflows/rust.yml:
##########
@@ -68,6 +71,12 @@ jobs:
- name: Check workspace without default features
run: cargo check --no-default-features -p datafusion
+ - name: Check tests in each package
+ run: |
+ for package in $(cargo metadata --no-deps --format-version 1 | jq
-r '.packages[].name'); do
+ cargo check --tests --package "$package" || exit 1
+ done
Review Comment:
I am not sure if we need `--no-default-features` to check tests 🤔
##########
.github/workflows/rust.yml:
##########
@@ -68,6 +71,12 @@ jobs:
- name: Check workspace without default features
run: cargo check --no-default-features -p datafusion
+ - name: Check tests in each package
+ run: |
+ for package in $(cargo metadata --no-deps --format-version 1 | jq
-r '.packages[].name'); do
+ cargo check --tests --package "$package" || exit 1
+ done
Review Comment:
I am not sure if we need `--no-default-features` to check tests 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
