comphead commented on code in PR #7945: URL: https://github.com/apache/arrow-datafusion/pull/7945#discussion_r1374839275
########## datafusion/sqllogictest/test_files/select.slt: ########## @@ -848,6 +848,11 @@ statement error DataFusion error: Error during planning: EXCLUDE or EXCEPT conta SELECT * EXCLUDE(a, a) FROM table1 +# if EXCEPT all the columns, query should still succeed but return empty Review Comment: thanks @Jefffrey i would also add more tricky test cases, where column names are in different order, duplicated. like ``` SELECT * EXCEPT(d, b, c, a, a, b, c, d) FROM table1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
