eeroel commented on code in PR #37868:
URL: https://github.com/apache/arrow/pull/37868#discussion_r1375235176
##########
python/pyarrow/tests/test_dataset.py:
##########
@@ -981,6 +981,48 @@ def test_make_fragment(multisourcefs):
assert row_group_fragment.row_groups == [0]
[email protected]
[email protected]
+def test_make_fragment_with_size(s3_example_simple):
Review Comment:
Looked into this further, the incomplete data issue was just a bug in the
test so a false alarm. But basically this test can't use local or mock
filesystems because they don't currently implement `OpenInputFile` that takes
`FileInfo`, so the size argument just gets ignored. Given this, do you think it
would be OK to just use S3 here, as that is one concrete implementation in
which this optimization is used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
