quanghgx commented on PR #38390: URL: https://github.com/apache/arrow/pull/38390#issuecomment-1784149804
> (I didn't go through the issue carefully, but would `CheckClosed` function like S3 Filesystem better here?) > > e.g. https://github.com/apache/arrow/blob/main/cpp/src/arrow/filesystem/s3fs.cc#L1249 Thanks for your hint. Refactored the checking into separate method. Use "Assert" here because it will throw instead of return arrow::Status. As operation on closed object is not a normal application flow. Please help take a look again, @mapleFU -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
