Joseph-Rance commented on code in PR #4773:
URL: https://github.com/apache/arrow-rs/pull/4773#discussion_r1375485912
##########
parquet_derive/src/lib.rs:
##########
@@ -95,7 +95,7 @@ pub fn parquet_record_writer(input: proc_macro::TokenStream)
-> proc_macro::Toke
field_infos.iter().map(|x| x.parquet_type()).collect();
(quote! {
- impl #generics ::parquet::record::RecordWriter<#derived_for #generics> for
&[#derived_for #generics] {
+ impl #generics ::parquet::record::RecordWriter<#derived_for #generics> for
Vec<#derived_for #generics> {
Review Comment:
I made the change to make the reader and writer both be for the same type.
On second thought perhaps also not worth breaking existing code that uses this
macro for no reason, so I'll switch back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
