viirya commented on code in PR #7969:
URL: https://github.com/apache/arrow-datafusion/pull/7969#discussion_r1375524481
##########
datafusion/common/src/scalar.rs:
##########
@@ -2234,28 +2239,20 @@ impl ScalarValue {
}
DataType::Utf8 => typed_cast!(array, index, StringArray, Utf8),
DataType::LargeUtf8 => typed_cast!(array, index, LargeStringArray,
LargeUtf8),
- DataType::List(nested_type) => {
+ DataType::List(_) => {
let list_array = as_list_array(array);
- let arr = match list_array.is_null(index) {
- true => new_null_array(nested_type.data_type(), 0),
- false => {
- let nested_array = list_array.value(index);
- Arc::new(wrap_into_list_array(nested_array))
- }
- };
+ let nested_array = list_array.value(index);
+ // Produces a single element `ListArray` with the value at
`index`.
+ let arr = Arc::new(wrap_into_list_array(nested_array));
ScalarValue::List(arr)
}
// TODO: There is no test for FixedSizeList now, add it later
- DataType::FixedSizeList(nested_type, _len) => {
Review Comment:
We can add some tests for `FixedSizeList`. I can do it in other follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
