paleolimbot commented on code in PR #1220:
URL: https://github.com/apache/arrow-adbc/pull/1220#discussion_r1376186210
##########
r/adbcsnowflake/tools/download-go-vendor-archive.R:
##########
@@ -15,20 +15,14 @@
# specific language governing permissions and limitations
# under the License.
-PKG_CPPFLAGS=-I$(CURDIR) -DADBC_EXPORT=""
-PKG_LIBS=-L$(CURDIR)/go -ladbc_driver_snowflake
+uri <- Sys.getenv("R_ADBCSNOWFLAKE_VENDORED_DEPENDENCY_URI", "")
-CGO_CC = `"${R_HOME}/bin${R_ARCH_BIN}/R.exe" CMD config CC`
-CGO_CXX = `"${R_HOME}/bin${R_ARCH_BIN}/R.exe" CMD config CXX`
-CGO_CFLAGS = $(ALL_CPPFLAGS)
-GO_BIN = $(CURDIR)/go/tmp/go/bin/go.exe
+if (identical(uri, "")) {
+ # When there is a home for this that is not a local file:// URI,
+ # this is where we would set the default.
Review Comment:
Perhaps in subsequent releases...for the first one I think I'll do Zenodo as
they suggested. It may take a few iterations to get the details such that the
submission is accepted and it's slightly easier to iterate outside the official
framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
