crepererum commented on code in PR #5006:
URL: https://github.com/apache/arrow-rs/pull/5006#discussion_r1376352427
##########
parquet_derive/src/parquet_field.rs:
##########
@@ -427,13 +427,9 @@ impl Field {
quote! {
::chrono::naive::NaiveDateTime::from_timestamp_millis(vals[i]).unwrap() }
}
Some(ThirdPartyType::ChronoNaiveDate) => {
+ // NaiveDateTime::UNIX_EPOCH.num_days_from_ce() == 719163
quote! {
-
::chrono::naive::NaiveDate::from_num_days_from_ce_opt(vals[i]
- + ((::chrono::naive::NaiveDate::from_ymd_opt(1970, 1,
1).unwrap()
- .signed_duration_since(
- ::chrono::naive::NaiveDate::from_ymd_opt(0, 12,
31).unwrap()
- )
- ).num_days()) as i32).unwrap()
+
::chrono::naive::NaiveDate::from_num_days_from_ce_opt(vals[i] + 719163).unwrap()
Review Comment:
ahhh, this is what it is for, interesting.
Either way, I would be happy if we don't introduce more panicky code paths.
IIRC there's `checked_add` which pretty much solves the issue and the parquet
error struct probably has some variant that would be fitting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
