zeroshade commented on code in PR #35769:
URL: https://github.com/apache/arrow/pull/35769#discussion_r1376458006
##########
go/arrow/ipc/file_reader.go:
##########
@@ -476,6 +487,9 @@ func (ctx *arrayLoaderContext) loadArray(dt arrow.DataType)
arrow.ArrayData {
case *arrow.BinaryType, *arrow.StringType, *arrow.LargeStringType,
*arrow.LargeBinaryType:
return ctx.loadBinary(dt)
+ case arrow.BinaryViewDataType:
Review Comment:
`BinaryViewDataType` is an interface, not a concrete type.
`StringViewDataType` implements the `BinaryViewDataType` interface. The
concrete types are `BinaryViewType` and `StringViewType`. The types that end
with `DataType` in the name are interfaces (like `FixedWidthDataType`). So we
don't need a separate case for `StringViewType` because they are processed
identically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
