mapleFU commented on PR #38390:
URL: https://github.com/apache/arrow/pull/38390#issuecomment-1785555621
```c++
Status Close() override {
if (!closed_) {
// Make idempotent
closed_ = true;
if (row_group_writer_ != nullptr) {
auto row_group_writer = std::move(row_group_writer_);
PARQUET_CATCH_NOT_OK(row_group_writer->Close());
}
PARQUET_CATCH_NOT_OK(writer_->Close());
}
```
Actually this change LGTM. But I'm not fully understand why
`row_group_writer_` will be double-closed. For example, when call
`FileWriter::Close` twice, the `closed_` will be true, so `row_group_writer_`
will only close once. Did I miss something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
