alamb commented on code in PR #7989:
URL: https://github.com/apache/arrow-datafusion/pull/7989#discussion_r1376742404
##########
datafusion/common/src/scalar.rs:
##########
@@ -1802,52 +1658,12 @@ impl ScalarValue {
/// assert_eq!(result, &expected);
/// ```
pub fn new_list(values: &[ScalarValue], data_type: &DataType) -> ArrayRef {
- Arc::new(match data_type {
Review Comment:
I am not sure why this function was implemented like this, but it is much
more concisely (and completely) implemented in terms of arrays and offsets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
