2010YOUY01 commented on code in PR #7996:
URL: https://github.com/apache/arrow-datafusion/pull/7996#discussion_r1377096909
##########
datafusion/physical-expr/src/expressions/column.rs:
##########
@@ -176,7 +176,7 @@ impl PhysicalExpr for UnKnownColumn {
/// Evaluate the expression
fn evaluate(&self, _batch: &RecordBatch) -> Result<ColumnarValue> {
- plan_err!("UnKnownColumn::evaluate() should not be called")
+ exec_err!("UnKnownColumn::evaluate() should not be called")
Review Comment:
If it means this line is unreachable, it should be Internal Error: if it's
reached then there must be a bug in Datafusion (I remember it will print an
error message to let the user file a GitHub issue for such error type)
##########
datafusion/physical-expr/src/expressions/no_op.rs:
##########
@@ -65,7 +65,7 @@ impl PhysicalExpr for NoOp {
}
fn evaluate(&self, _batch: &RecordBatch) -> Result<ColumnarValue> {
- plan_err!("NoOp::evaluate() should not be called")
+ exec_err!("NoOp::evaluate() should not be called")
Review Comment:
Seems also Internal Error 🤔
##########
datafusion/physical-expr/src/expressions/no_op.rs:
##########
@@ -65,7 +65,7 @@ impl PhysicalExpr for NoOp {
}
fn evaluate(&self, _batch: &RecordBatch) -> Result<ColumnarValue> {
- plan_err!("NoOp::evaluate() should not be called")
+ exec_err!("NoOp::evaluate() should not be called")
Review Comment:
Seems also Internal Error 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
