alamb commented on code in PR #7998:
URL: https://github.com/apache/arrow-datafusion/pull/7998#discussion_r1377328247
##########
datafusion/sql/src/expr/function.rs:
##########
@@ -36,44 +36,57 @@ use super::arrow_cast::ARROW_CAST_NAME;
impl<'a, S: ContextProvider> SqlToRel<'a, S> {
pub(super) fn sql_function_to_expr(
&self,
- mut function: SQLFunction,
+ function: SQLFunction,
schema: &DFSchema,
planner_context: &mut PlannerContext,
) -> Result<Expr> {
- let name = if function.name.0.len() > 1 {
+ let SQLFunction {
Review Comment:
I also changed to use this explicit destructuring, so if other new fields
are added the compiler will tell us in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
