llama90 commented on PR #38526: URL: https://github.com/apache/arrow/pull/38526#issuecomment-1787391401
> Should we use `static_cast<std::default_random_engine::result_type>` for better portability? Since `std::default_random_engine` is implementation defined, we can't be sure it's `unsigned int` on all platforms. Umm... I haven't even thought about that. you are right. I just tried to fix it in my environment. I have to more think what is the best approach for this... 😱 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
