jonahgao commented on PR #7997: URL: https://github.com/apache/arrow-datafusion/pull/7997#issuecomment-1787422055
I have concerns about the correctness of this optimization rule. We might need to consider the following scenario. ```sh DataFusion CLI v32.0.0 ❯ select cast(9223372036854775807 as float)=cast(9223372036854775806 as float); +---------------------------------------------------------+ | Int64(9223372036854775807) = Int64(9223372036854775806) | +---------------------------------------------------------+ | true | +---------------------------------------------------------+ 1 row in set. Query took 0.003 seconds. ``` These two numbers, `9223372036854775807` and `9223372036854775806`, belong to different groups if we group by them. However, they will become the same after casting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
