CurtHagenlocher commented on code in PR #1241:
URL: https://github.com/apache/arrow-adbc/pull/1241#discussion_r1377829880
##########
csharp/src/Apache.Arrow.Adbc/C/CAdbcDriverImporter.cs:
##########
@@ -331,155 +331,72 @@ public override unsafe UpdateResult ExecuteUpdate()
public override object GetValue(IArrowArray arrowArray, Field
field, int index)
Review Comment:
Is there any real difference between this and the BigQueryStatement
implementaton now? Could a base implementation be moved to AdbcStatement?
##########
csharp/src/Client/AdbcDataReader.cs:
##########
@@ -196,7 +212,33 @@ public override string GetString(int ordinal)
public override object GetValue(int ordinal)
{
- return GetValue(this.recordBatch?.Column(ordinal), ordinal);
+ object value = GetValue(this.recordBatch?.Column(ordinal),
ordinal);
+
+ if (value == null)
+ return null;
+
+ if(value.GetType() == typeof(SqlDecimal))
Review Comment:
if (value is SqlDecimal dvalue)
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
