kazuyukitanimura commented on code in PR #8002:
URL: https://github.com/apache/arrow-datafusion/pull/8002#discussion_r1378183439
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -328,7 +328,9 @@ impl GroupedHashAggregateStream {
.collect();
let name = format!("GroupedHashAggregateStream[{partition}]");
- let reservation =
MemoryConsumer::new(name).register(context.memory_pool());
+ let reservation = MemoryConsumer::new(name)
Review Comment:
Yes, looks good.
Another idea to test is that to write a test aggregation job with small
memory pool size that fails with the greedy pool but succeeds with the fair
pool. Not sure if we can write such case...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
