alamb commented on PR #7978:
URL: 
https://github.com/apache/arrow-datafusion/pull/7978#issuecomment-1788677447

   > Moving BuiltinScalarFunctions entirely into phys-expr crate and extend 
ScalarUDF sounds like a good idea, I will experiment if this approach is doable
   
   Thank you @2010YOUY01  -- I am pretty excited that this approach has the 
benefits of
   1. Minimizes API changes
   2. Ensures that UDFs have the same breadth of functionality as built in 
functions
   
   Some steps that might get us there might be to make the fields of 
`ScalarUDF` non `pub`, which would be a breaking change, but would would then 
let us extend the API in a non breaking way
   
   ```rust
   let udf = ScalarUDF::new(..)
     .with_aliases(["foo", "bar"]);
   ```
   
   Over time, we could then even introduce a new trait API (and internally 
change how ScalarUDF is implemented) without making additional breaking changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to