comphead commented on code in PR #8019:
URL: https://github.com/apache/arrow-datafusion/pull/8019#discussion_r1379167761
##########
datafusion/physical-plan/src/lib.rs:
##########
@@ -166,19 +179,21 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// The default implementation returns `false`
///
/// WARNING: if you override this default, you *MUST* ensure that
- /// the operator's maintains the ordering invariant or else
+ /// the `ExecutionPlan`'s maintains the ordering invariant or else
/// DataFusion may produce incorrect results.
fn maintains_input_order(&self) -> Vec<bool> {
vec![false; self.children().len()]
}
- /// Specifies whether the operator benefits from increased parallelization
- /// at its input for each child. If set to `true`, this indicates that the
- /// operator would benefit from partitioning its corresponding child
- /// (and thus from more parallelism). For operators that do very little
work
- /// the overhead of extra parallelism may outweigh any benefits
+ /// Specifies whether the `ExecutionPlan` benefits from increased
+ /// parallelization at its input for each child.
///
- /// The default implementation returns `true` unless this operator
+ /// If returns `true`, the `ExecutionPlan` would benefit from partitioning
Review Comment:
👍
##########
datafusion/physical-plan/src/lib.rs:
##########
@@ -166,19 +179,21 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// The default implementation returns `false`
///
/// WARNING: if you override this default, you *MUST* ensure that
- /// the operator's maintains the ordering invariant or else
+ /// the `ExecutionPlan`'s maintains the ordering invariant or else
/// DataFusion may produce incorrect results.
fn maintains_input_order(&self) -> Vec<bool> {
vec![false; self.children().len()]
}
- /// Specifies whether the operator benefits from increased parallelization
- /// at its input for each child. If set to `true`, this indicates that the
- /// operator would benefit from partitioning its corresponding child
- /// (and thus from more parallelism). For operators that do very little
work
- /// the overhead of extra parallelism may outweigh any benefits
+ /// Specifies whether the `ExecutionPlan` benefits from increased
+ /// parallelization at its input for each child.
///
- /// The default implementation returns `true` unless this operator
+ /// If returns `true`, the `ExecutionPlan` would benefit from partitioning
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
