crepererum commented on code in PR #5030:
URL: https://github.com/apache/arrow-rs/pull/5030#discussion_r1380402269
##########
object_store/src/lib.rs:
##########
@@ -443,6 +453,13 @@
))]
compile_error!("Features 'gcp', 'aws', 'azure', 'http' are not supported on
wasm.");
+#[cfg(all(
+ feature = "cloud",
+ not(feature = "tls-native-roots"),
+ not(feature = "tls-webpki-roots"),
+))]
+compile_error!("Feature 'cloud' needs at a CA root feature, use either
'tls-native-roots' or 'tls-webpki-roots'.");
Review Comment:
Technically you could silently ignore that and do not use any CA source
(apart from the manual one). However this leads to runtime errors ("invalid
cert") and is likely surprising to many users (esp. if they don't test any real
cloud store in CI), so I've opted for forcing people to make a choice during
compilation time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
