davidhcoe commented on issue #1242: URL: https://github.com/apache/arrow-adbc/issues/1242#issuecomment-1790905215
> In the case of hitting https://github.com/apache/arrow/blob/c49e24273160ac1ce195f02dbd14acd7d0f6945e/go/arrow/compute/internal/kernels/helpers.go#L592 it should only hit that if we're actually hitting the case where the value itself falls outside the range (since it should only error by actually _checking_ that the value didn't fit), but for the early failure due to the scale and precision I guess we can add an option upstream to allow a consumer to request it to bypass that validation and let it just assume that everything will fit? > > I'm not sure how I feel about that and I wish that snowflake would just return the correct type in the first place, but I doubt we'd be able to convince them to change how they return the data.... Right. I tried adding logic to check whether `useHighPrecision` could be used given the precision and scale, and the current answer is false, so it falls to the logic of trying to do the math on the larger values that don't fit. So that didn't turn out to be a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
