sgilmore10 opened a new pull request, #38561:
URL: https://github.com/apache/arrow/pull/38561
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
We should implement a static `fromMATLAB` method for `arrow.array.ListArray`
that takes in a MATLAB `cell` array and returns an instance of
`arrow.array.ListArray`. Adding this method enables users to create an
`arrow.array.ListArray` by passing a MATLAB `cell` array to the `arrow.array`
gateway function:
```matlab
>> C = {[1 2 3], [4 5], 6};
>> array = arrow.array(C)
array =
ListArray with 3 elements and 0 null values:
[
[
1,
2,
3
],
[
4,
5
],
[
6
]
]
```
Internally, the `arrow.array` gateway function will call
`arrow.array.ListArray.fromMATLAB` to construct a `ListArray` from the given
`cell` array.
### What changes are included in this PR?
1. Implemented `fromMATLAB` method on `arrow.array.ListArray`. This method
accepts a MATLAB `cell` array and returns an instance of
`arrow.array.ListArray`.
2. Set the `MatlabConstructor` property of `arrow.type.traits.ListTraits` to
`@arrow.array.ListArray.fromMATLAB`.
3. Added a switch case for `"cell"` to the `arrow.array` gateway function
that invokes `arrow.array.ListArray.fromMATLAB` with the input `cell` array.
### Are these changes tested?
Yes. I added a new test class to the `test/arrow/array/list` folder named
`tFromMATLAB.m`.
### Are there any user-facing changes?
Yes. Users can now create instances of `arrow.array.ListArray` by passing
`cell` arrays to `arrow.array`:
```matlab
>> C = {["A" "B"], ["C" "D" "E"], missing, ["F" "G"], string.empty(0, 1)};
>> array = arrow.array(C)
array =
ListArray with 5 elements and 1 null value:
[
[
"A",
"B"
],
[
"C",
"D",
"E"
],
null,
[
"F",
"G"
],
[]
]
```
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line
below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid
data to be produced, or (c) a bug that causes a crash (even when the API
contract is upheld). We use this to highlight fixes to issues that may affect
users without their knowledge. For this reason, fixing bugs that cause errors
don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
