alamb opened a new pull request, #8034: URL: https://github.com/apache/arrow-datafusion/pull/8034
Draft as it builds on https://github.com/apache/arrow-datafusion/pull/8006 ## Which issue does this PR close? related to https://github.com/apache/arrow-datafusion/pull/8006 ## Rationale for this change As I proposed in https://github.com/apache/arrow-datafusion/pull/8006#discussion_r1380454715 I think making stucts rather than typedefs leads to easier to maintain code as the functionality is easier to find and it allows / encourages more documentation and encapsulation This also was a good excuse for me to try and work with the code some ## What changes are included in this PR? 1. Make `EquivalenceClass` a real structure rather than a typedef 2. Add docs I actually think maybe the right thing to do is to call this thing `PhysicalExprSet` or something as it is more general than just equivalence classes We could move it all into a new module (rather than calling functions in utils). I'll try and revive this PR once https://github.com/apache/arrow-datafusion/pull/8006 gets merged ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 4. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
