tustvold commented on code in PR #5015:
URL: https://github.com/apache/arrow-rs/pull/5015#discussion_r1380742186
##########
arrow-cast/src/cast.rs:
##########
@@ -2317,6 +2341,19 @@ fn value_to_string<O: OffsetSizeTrait>(
Ok(Arc::new(builder.finish()))
}
+fn cast_numeric_to_binary<FROM: ArrowPrimitiveType, O: OffsetSizeTrait>(
Review Comment:
That might be better as a custom kernel then? Perhaps kernels mirroring
https://doc.rust-lang.org/std/primitive.i32.html#method.to_be and
https://doc.rust-lang.org/std/primitive.i32.html#method.to_le ?
I think it would be good to avoid adding data type specific options to
CastOptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
