indigophox commented on code in PR #34817:
URL: https://github.com/apache/arrow/pull/34817#discussion_r1380907949
##########
cpp/src/arrow/flight/sql/types.h:
##########
@@ -44,6 +44,23 @@ using SqlInfoResult =
/// \brief Map SQL info identifier to its value.
using SqlInfoResultMap = std::unordered_map<int32_t, SqlInfoResult>;
+/// \brief Variant supporting all possible types for SetSessionOptions
+using SessionOptionValue =
+ std::variant<std::string, bool, int32_t, int64_t, float, double,
std::vector<std::string>>;
+
+enum struct SessionOptionValueType : size_t {
+ kString, kBool, kInt32, kInt64, kFloat, kDouble, kStringList
+};
+
+struct ARROW_FLIGHT_SQL_EXPORT SessionOption {
+ std::string option_name;
+ SessionOptionValue option_value;
+
+ explicit SessionOption(std::string name, SessionOptionValue val)
+ : option_name{ std::move(name) }, option_value{ std::move(val) } {}
+ SessionOption() {}
Review Comment:
(Code removed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
