alamb commented on code in PR #8040: URL: https://github.com/apache/arrow-datafusion/pull/8040#discussion_r1380844684
########## docs/source/user-guide/sql/scalar_functions.md: ########## @@ -1407,10 +1408,12 @@ to_timestamp(expression) ### `to_timestamp_millis` -Converts a value to RFC3339 millisecond timestamp format (`YYYY-MM-DDT00:00:00.000Z`). -Supports timestamp, integer, and unsigned integer types as input. -Integers and unsigned integers are parsed as Unix nanosecond timestamps and Review Comment: this text incorrectly implies numeric arguments are interpreted as `nanoseconds` which is not the case (they are treated as `milliseconds`). I also tried to clean up the language about what a "unix timetamp" meant (really means seconds from unix epoch) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
