ovr commented on a change in pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#discussion_r556526632
##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -776,6 +785,14 @@ pub(crate) fn create_group_by_values(
for i in 0..group_by_keys.len() {
let col = &group_by_keys[i];
match col.data_type() {
+ DataType::Float32 => {
Review comment:
@alamb I've added tests, but I found a strange bug probably with count.
https://github.com/apache/arrow/pull/9175/commits/012c1ac0151878f43d60e3a7090f5b99947e3294#diff-4b06103cf2132b1ab297fbe8cd42622ecbe1109ea26df7d8b358fa36d739549cR357
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
