joellubi commented on code in PR #38385:
URL: https://github.com/apache/arrow/pull/38385#discussion_r1382393086
##########
cpp/src/arrow/flight/sql/client.cc:
##########
@@ -256,6 +256,88 @@ arrow::Result<int64_t>
FlightSqlClient::ExecuteSubstraitUpdate(
return update_result.record_count();
}
+arrow::Result<int64_t> FlightSqlClient::ExecuteIngest(
+ const FlightCallOptions& options,
+ const std::shared_ptr<RecordBatchReader>& reader,
+ const IngestMode& mode,
+ const std::string& table, const std::string& schema,
+ const std::string& catalog, const bool temporary,
+ const Transaction& transaction,
+ const std::map<std::string, std::string>& ingest_options) {
+ flight_sql_pb::CommandStatementIngest command;
+
+ flight_sql_pb::CommandStatementIngest_IngestMode pb_ingest_mode;
+ switch (mode)
+ {
Review Comment:
I fixed some more linting issues that appear to be failing in CI. It's not
clear to me that this resolves 100% of the issues because my local run of
`archery lint --cpplint --clang-format --clang-tidy --fix` still exits with a
nonzero status code but doesn't give a clear indication of what failed.
Two other CI checks appear to have failed as well, but it's not clear that
they are related to these changes. Any insight into these failures on your end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
