Re: [PR] GH-38558: [C++] Add support for null sort option per sort key [arrow]

[via GitHub]

kou commented on code in PR #38584:
URL: https://github.com/apache/arrow/pull/38584#discussion_r1382721732


##########
cpp/src/arrow/compute/api_vector.h:
##########
@@ -177,21 +174,17 @@ class ARROW_EXPORT RankOptions : public FunctionOptions {
   };
 
   explicit RankOptions(std::vector<SortKey> sort_keys = {},
-                       NullPlacement null_placement = NullPlacement::AtEnd,
                        Tiebreaker tiebreaker = RankOptions::First);
   /// Convenience constructor for array inputs
   explicit RankOptions(SortOrder order,
-                       NullPlacement null_placement = NullPlacement::AtEnd,

Review Comment:
   Sorry, I can't understand what you said...
   
   I think that we need this change:
   
   ```diff
   diff --git a/cpp/src/arrow/compute/api_vector.h 
b/cpp/src/arrow/compute/api_vector.h
   index 0233090ef..64d6c4112 100644
   --- a/cpp/src/arrow/compute/api_vector.h
   +++ b/cpp/src/arrow/compute/api_vector.h
   @@ -183,7 +183,7 @@ class ARROW_EXPORT RankOptions : public FunctionOptions {
      explicit RankOptions(SortOrder order,
                           NullPlacement null_placement = NullPlacement::AtEnd,
                           Tiebreaker tiebreaker = RankOptions::First)
   -      : RankOptions({SortKey("", order)}, null_placement, tiebreaker) {}
   +      : RankOptions({SortKey("", order, null_placement)}, tiebreaker) {}
    
      static constexpr char const kTypeName[] = "RankOptions";
      static RankOptions Defaults() { return RankOptions(); }
   ```
   
   Do you want to say that we don't need to specify `NullPlacement` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org