lidavidm commented on code in PR #1259:
URL: https://github.com/apache/arrow-adbc/pull/1259#discussion_r1383392846
##########
r/adbcsqlite/configure:
##########
Review Comment:
SQLite itself doesn't provide an ifdef? That's unfortunate
##########
c/driver/sqlite/sqlite.c:
##########
@@ -320,6 +321,12 @@ AdbcStatusCode SqliteConnectionSetOption(struct
AdbcConnection* connection,
free(conn->extension_path);
conn->extension_path = NULL;
return ADBC_STATUS_OK;
+#else
+ SetError(error,
+ "[SQLite] This build of the ADBC SQLite driver does not support
extension "
+ "loading");
+ return ADBC_STATUS_INTERNAL;
Review Comment:
nit: NOT_IMPLEMENTED?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
