alamb opened a new pull request, #8066:
URL: https://github.com/apache/arrow-datafusion/pull/8066

   ## Which issue does this PR close?
   
   
   Part of https://github.com/apache/arrow-datafusion/issues/7988
   
   
   
   ## Rationale for this change
   As pointed out by @jayzhan211  in 
https://github.com/apache/arrow-datafusion/pull/8054#discussion_r1382678796, 
sqllogictests tests are easier to maintain and also cover the logic end to end. 
   
   I was going to port the rest of the tests for `array_replace` to `array.slt` 
and when I went to do so I found out they were already there. 
   
   
   ## What changes are included in this PR?
   1. Remove unit tests from `array_expressions.rs`
   2. Reformat tests in `array.slt` to make it clearer what is tested (and in 
particular all the cases are already covered)
   
   ## Are these changes tested?
   
   Yes, by existing tests
   
   ## Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to