Dandandan opened a new issue, #8067: URL: https://github.com/apache/arrow-datafusion/issues/8067
### Is your feature request related to a problem or challenge? Currently the `CountAccumulator` implementation requires `values: &[ArrayRef]` to be passed. In order to eliminate scanning a (first) column, we need to be able to accept a `RecordBatch` or `num_rows` instead of `values: &[ArrayRef]`. ### Describe the solution you'd like Rather than changing every method to accept a `RecordBatch` (and needing to update the code), I propose adding two new methods: `update_record_batch(&mut self, recordbatch: &RecordBatch)` `retract_record_batch(&mut self, recordbatch: &RecordBatch)` The default implementation of the methods can use `update_batch` and `update_record_batch` (i.e. assume having at least one column). In the aggregation code, we call `update_record_batch`/`retract_record_batch` instead. We should remove the code adding a first column for `Count` in "push_down_projection" . ### Describe alternatives you've considered _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
