alamb commented on code in PR #8049:
URL: https://github.com/apache/arrow-datafusion/pull/8049#discussion_r1384954660
##########
datafusion/physical-plan/src/limit.rs:
##########
@@ -748,7 +773,58 @@ mod tests {
assert_eq!(row_count, Precision::Exact(10));
let row_count = row_number_statistics_for_global_limit(5,
Some(10)).await?;
- assert_eq!(row_count, Precision::Exact(15));
+ assert_eq!(row_count, Precision::Exact(10));
+
+ let row_count = row_number_statistics_for_global_limit(400,
Some(10)).await?;
+ assert_eq!(row_count, Precision::Exact(0));
+
+ let row_count = row_number_statistics_for_global_limit(398,
Some(10)).await?;
+ assert_eq!(row_count, Precision::Exact(2));
+
+ let row_count = row_number_statistics_for_global_limit(398,
Some(1)).await?;
+ assert_eq!(row_count, Precision::Exact(1));
+
+ let row_count = row_number_statistics_for_global_limit(398,
None).await?;
+ assert_eq!(row_count, Precision::Exact(2));
+
+ let row_count =
+ row_number_statistics_for_global_limit(0, Some(usize::MAX)).await?;
+ assert_eq!(row_count, Precision::Exact(400));
+
+ let row_count =
+ row_number_statistics_for_global_limit(398,
Some(usize::MAX)).await?;
+ assert_eq!(row_count, Precision::Exact(2));
+
+ let row_count =
Review Comment:
```suggestion
// test inexact input statistics
let row_count =
```
This threw me for quite a while while trying to figure out why a fetch of 10
resulted in inexact statistics. Now that I see the difference is the input
statistics are inexact it makes much more sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
