comphead commented on code in PR #8070:
URL: https://github.com/apache/arrow-datafusion/pull/8070#discussion_r1385214175
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -747,27 +747,38 @@ where
Ok(())
}
-/// A stream that issues [RecordBatch]es as they arrive from the right of the
join.
+/// [`Stream`] for [`HashJoinExec`] that does the actual join.
+///
+/// This stream:
+///
+/// 1. Reads the entire left input and constructs a hash table
Review Comment:
```suggestion
/// 1. Reads the entire left input(build) and constructs a hash table
```
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -747,27 +747,38 @@ where
Ok(())
}
-/// A stream that issues [RecordBatch]es as they arrive from the right of the
join.
+/// [`Stream`] for [`HashJoinExec`] that does the actual join.
+///
+/// This stream:
+///
+/// 1. Reads the entire left input and constructs a hash table
+///
+/// 2. Streams [RecordBatch]es as they arrive from the right input and joins
Review Comment:
```suggestion
/// 2. Streams [RecordBatch]es as they arrive from the right input(probe)
and joins
```
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -1003,13 +1028,14 @@ impl HashJoinStream {
cx: &mut std::task::Context<'_>,
) -> Poll<Option<Result<RecordBatch>>> {
let build_timer = self.join_metrics.build_time.timer();
+ // build hash table from left (build) side, if not yet done
Review Comment:
that looks great @alamb
Thanks for leaving comments where is build and where is a probe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
