viirya commented on code in PR #8072:
URL: https://github.com/apache/arrow-datafusion/pull/8072#discussion_r1385314447
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1271,8 +1272,11 @@ mod tests {
fn new_spill_ctx(batch_size: usize, max_memory: usize) -> Arc<TaskContext>
{
let session_config = SessionConfig::new().with_batch_size(batch_size);
let runtime = Arc::new(
-
RuntimeEnv::new(RuntimeConfig::default().with_memory_limit(max_memory, 1.0))
- .unwrap(),
+ RuntimeEnv::new(
Review Comment:
Hmm, I guess so though I'm not very sure. I just feel that for spilling it
makes more sense to use `FairSpillPool` and looks like it can fix the test
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
