tustvold commented on code in PR #5053:
URL: https://github.com/apache/arrow-rs/pull/5053#discussion_r1385583044
##########
parquet/src/basic.rs:
##########
@@ -215,8 +215,20 @@ pub enum Repetition {
// Mirrors `parquet::Encoding`
/// Encodings supported by Parquet.
+///
/// Not all encodings are valid for all types. These enums are also used to
specify the
/// encoding of definition and repetition levels.
+///
+/// Additionally, not all encodings are well supported by the broader
ecosystem.
Review Comment:
It is mainly newer systems like DuckDB that have poor support for these
encodings, I have opted to reword this slightly to emphasise that the defaults
are supported by everything, as opposed to casting aspersions on the other
encodings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
