2010YOUY01 commented on issue #8045: URL: https://github.com/apache/arrow-datafusion/issues/8045#issuecomment-1800831991
> @2010YOUY01 I have updated the task list on this ticket based on your investigation. Please take a look when you have a chance. > > The only one I don't understand is > > > [return_type()](https://github.com/apache/arrow-datafusion/blob/308c35404939ed39e4e398054d6fc78c89817109/datafusion/expr/src/built_in_function.rs#L486) now do both input validation and generating output, these responsibilities have to be separated > > Can you explain why validation of input types + output type calculation need to be separated? I think it's a simple refactor, I can open a PR to better explain and solve this issue > > Can they be moved into function implementations > > @2010YOUY01 -- I totally agree this could be cleaned up. Moving it to specific implementations would be great. Could you make a PR to do so? Sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
