alamb commented on issue #7988: URL: https://github.com/apache/arrow-datafusion/issues/7988#issuecomment-1802251050
I think there are still several examples of macros that could/should be functions: - [ ] array_remove: https://github.com/apache/arrow-datafusion/blob/724bafd4de98eff8d6ffd67942d29d0f9faf2aa3/datafusion/physical-expr/src/array_expressions.rs#L1131-L1202 - [ ] array_positions: https://github.com/apache/arrow-datafusion/blob/724bafd4de98eff8d6ffd67942d29d0f9faf2aa3/datafusion/physical-expr/src/array_expressions.rs#L1066 - [ ] array_repeat: https://github.com/apache/arrow-datafusion/blob/724bafd4de98eff8d6ffd67942d29d0f9faf2aa3/datafusion/physical-expr/src/array_expressions.rs#L844-L961 In general, I think we should be aiming for the removal of macros in the array functions as the macros are unecessary, harder to maintain, and generate more code than is necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
