comphead commented on PR #7897: URL: https://github.com/apache/arrow-datafusion/pull/7897#issuecomment-1802392855
> > Thanks @edmondop for keep improving the PR Please also test > > > > * different datatypes, fixed len(int, float, etc) / variable(strings, inner arrays) > > * nulls > > * empty arrays > > > > we can put tests for every type and figure out if this needs to be fixed within this PR or we can create a followup PR > > Will do! Are the other cases for empty arrays that aren't there @comphead ? Now I can see ``` select array_union([1,2,3], []); ``` would be very nice to see ``` select array_union([], []); select array_union([[]], []); select array_union([[null]], []); select array_union([null], [null]); select array_union([[]], [[]]); select array_union(null, []); select array_union(null, null); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
